From 61aada601fe6ad068df4c960c34d7a77126a8bff Mon Sep 17 00:00:00 2001 From: Norris Mei Date: Thu, 12 Sep 2024 00:01:29 -0700 Subject: [PATCH] Scope query to org and use item_requests instead of request_items --- app/controllers/requests_controller.rb | 6 +++++- app/pdfs/picklists_pdf.rb | 16 +++++++++------- 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb index 565ce1b751..7b12f4c83c 100644 --- a/app/controllers/requests_controller.rb +++ b/app/controllers/requests_controller.rb @@ -41,7 +41,11 @@ def start end def print_unfulfilled - requests = Request.includes(partner: [:profile]).where(status: [0, 1]) + requests = current_organization + .requests + .includes(:item_requests, partner: [:profile]) + .where(status: [:pending, :started]) + .order(created_at: :desc) respond_to do |format| format.any do diff --git a/app/pdfs/picklists_pdf.rb b/app/pdfs/picklists_pdf.rb index a7bd84e438..7bb2d55176 100644 --- a/app/pdfs/picklists_pdf.rb +++ b/app/pdfs/picklists_pdf.rb @@ -81,9 +81,7 @@ def compute_and_render move_down 20 - items = request.request_items.map do |request_item| - RequestItem.from_json(request_item, request) - end + items = request.item_requests data = has_custom_units?(items) ? data_with_units(items) : data_no_units(items) font_size 11 @@ -134,7 +132,7 @@ def compute_and_render end def has_custom_units?(items) - Flipper.enabled?(:enable_packs) && items.any? { |item| item.unit } + Flipper.enabled?(:enable_packs) && items.any? { |item| item.request_unit } end def data_with_units(items) @@ -145,9 +143,11 @@ def data_with_units(items) "Differences / Comments"]] data + items.map do |i| - [i.item.name, + item_name = Item.find(i.item_id).name + + [item_name, i.quantity, - i.unit&.capitalize&.pluralize(i.quantity), + i.request_unit&.capitalize&.pluralize(i.quantity), "[ ]", ""] end @@ -160,7 +160,9 @@ def data_no_units(items) "Differences / Comments"]] data + items.map do |i| - [i.item.name, + item_name = Item.find(i.item_id).name + + [item_name, i.quantity, "[ ]", ""]