Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Drives -- expand export to be like Distribution etc #3431

Closed
2 tasks
cielf opened this issue Mar 5, 2023 · 10 comments · Fixed by #3478
Closed
2 tasks

Product Drives -- expand export to be like Distribution etc #3431

cielf opened this issue Mar 5, 2023 · 10 comments · Fixed by #3478
Assignees
Labels
Help Wanted Groomed + open to all!

Comments

@cielf
Copy link
Collaborator

cielf commented Mar 5, 2023

Summary

Although there is a product drive export, to be really useful, it needs to have the items in it, like we do with the distribution and the donation exports

Why?

Increased utility. Saving banks time.

Details

Criteria for completion

  • Functionality as described above is available
  • tests to support this functionality
@cielf cielf added the Help Wanted Groomed + open to all! label Mar 5, 2023
@anoosh96
Copy link
Contributor

Hey @cielf, I can take this up, can you please assign me this issue?

@cielf
Copy link
Collaborator Author

cielf commented Mar 15, 2023

@anosh96 You got it!

@anoosh96
Copy link
Contributor

anoosh96 commented Mar 16, 2023

Hi @cielf I need to clarify something. Do we need to have a column for each active item, whether or not they were received in the drive?, e.g if we have 90 active items, and only 8 of them were received in the drive then we will have 8 columns with their respective quantity and 82 columns with '0' as quantity.

@cielf
Copy link
Collaborator Author

cielf commented Mar 16, 2023

Yes, but also inactive ones, because they may be pulling a report across a significant period of time.

From the way your phrased your question -- I want to point out that the unfiltered export is across multiple product drives.

@anoosh96
Copy link
Contributor

thanks for clarification @cielf, can you please review the PR linked to this issue?

@cielf
Copy link
Collaborator Author

cielf commented Mar 20, 2023

Hi @anoosh96 I'm really busy early this week, but will take a look before the weekend if no one else beats me to it.

@anoosh96
Copy link
Contributor

hi @cielf, just a warm reminder about the PR review.

@cielf
Copy link
Collaborator Author

cielf commented Mar 24, 2023

@anoosh96 Will start looking at it today, but may have fragments of time while waiting for other processes to finish to look at it, I'm afraid.

@anoosh96
Copy link
Contributor

great, thanks @cielf

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

This issue has been inactive for 250 hours (10.42 days) and will be automatically unassigned after 110 more hours (4.58 days).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Groomed + open to all!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants