Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Organization update doesn't handle case where partner would have no request type set gracefully #3765

Closed
2 tasks
cielf opened this issue Jul 23, 2023 · 6 comments · Fixed by #3816
Closed
2 tasks

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 23, 2023

Summary

If an organization disallows a request type, and a partner only has that request type, the user will get a nasty error (i.e a 500 error) This should be handled gracefully with a friendly error message, naming the partner affected.

Why fix

It is, I will grant you, a rare case, but a bank should be able to be notified gracefully of the problem.

Details

If a bank tries to update their org, and their change would result in a partner not having any request capability, please display an error "Please update [partner name] so that they could make requests if you completed this change, then try again. Thank you."

Notes

There is an organization update service that seems to be checking if the organizations can make requests, but doesn't throw an error if they don't. That is related, but probably not the actual issue here.

Criteria for completion

  • System handles the case where a partner would be left with no request capability gracefully as described above
  • Tests to demonstrate this.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 23, 2023
@torienyart
Copy link
Contributor

Hi there! I'd like to make an attempt at tackling this, please!

@dorner
Copy link
Collaborator

dorner commented Jul 28, 2023

Go for it!

@torienyart
Copy link
Contributor

Just noting that I took a few days to get acquainted with the Repo before starting this ticket as it's my first! But I am getting pretty close and should have a PR soon :)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Sep 7, 2023
@torienyart torienyart removed their assignment Sep 13, 2023
@torienyart
Copy link
Contributor

I accidentally removed my assignment on this instead of a different one I was on! I am still plugging away at this and will hopefully have a final PR in tomorrow. Working with @dorner to work out a few kinks w/ CI.

@awwaiid
Copy link
Collaborator

awwaiid commented Oct 1, 2023

Thank you for your contribution! This is going out to the production humanessentials.app now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants