-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Organization update doesn't handle case where partner would have no request type set gracefully #3765
Comments
Hi there! I'd like to make an attempt at tackling this, please! |
Go for it! |
Just noting that I took a few days to get acquainted with the Repo before starting this ticket as it's my first! But I am getting pretty close and should have a PR soon :) |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
I accidentally removed my assignment on this instead of a different one I was on! I am still plugging away at this and will hopefully have a final PR in tomorrow. Working with @dorner to work out a few kinks w/ CI. |
Thank you for your contribution! This is going out to the production humanessentials.app now! |
Summary
If an organization disallows a request type, and a partner only has that request type, the user will get a nasty error (i.e a 500 error) This should be handled gracefully with a friendly error message, naming the partner affected.
Why fix
It is, I will grant you, a rare case, but a bank should be able to be notified gracefully of the problem.
Details
If a bank tries to update their org, and their change would result in a partner not having any request capability, please display an error "Please update [partner name] so that they could make requests if you completed this change, then try again. Thank you."
Notes
There is an organization update service that seems to be checking if the organizations can make requests, but doesn't throw an error if they don't. That is related, but probably not the actual issue here.
Criteria for completion
The text was updated successfully, but these errors were encountered: