Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive items should not appear in item selection drop downs for distributions. #3988

Closed
2 tasks
cielf opened this issue Dec 24, 2023 · 8 comments · Fixed by #4848
Closed
2 tasks

Inactive items should not appear in item selection drop downs for distributions. #3988

cielf opened this issue Dec 24, 2023 · 8 comments · Fixed by #4848

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 24, 2023

Summary

If you have "deleted" an item, it should not appear in item selection dropdowns for such functions as distributions.(They currently do).

Details

We recently made a change so that the InventoryItem is retained when the inventory item for a item drops to zero, in order to forestall some exceptions we were getting when such a thing could not be found.

However, now, if an item has had inventory, and then been "deleted" (i.e. is "inactive"), it is still showing up in the distribution dropdowns.

It shouldn't.

It also should not show up in any of the other "itemizables". On the original request around this, it was noted that they don't (as they shouldn't), but we should double-check.

Recreation

Sign in as org_admin
go into Inventory | Inventory Items and delete Adult Large/XL
Go to distributions
New Distribution
Fill in the partner and storage location. Check the list of items you can pick from. Adult Large XL will be there (at least with (0) for the amount.

Criteria for completion

  • Active items, and only active items should not appear in the dropdown lists for distribution, That is, inactive items should be excluded.
  • Test to that effect.
@rowenwillabus
Copy link
Contributor

I'll take this.

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Dec 24, 2023
@cielf
Copy link
Collaborator Author

cielf commented Dec 25, 2023

Cool. Thanks. I just thought of a possible "gotcha". When we're editing distributions, there may be inactive items in the distribution. We need to make sure that those aren't affected.

@rowenwillabus
Copy link
Contributor

Right. What I'm working on affects only the new method. I'll wrap this up within a few minutes.

Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Automatically unassigned after 7 days of inactivity.

@cielf
Copy link
Collaborator Author

cielf commented Mar 26, 2024

I'm pretty sure this has been fixed by a different PR now -- with another issue resulting. Will double check, and if so, close.

@dorner
Copy link
Collaborator

dorner commented May 24, 2024

@cielf reminder to take a look at this

@cielf
Copy link
Collaborator Author

cielf commented May 24, 2024

Apparently I'm mistaken. Inactive items are still appearing in item selection on new distributions on staging. They aren't on donations or purchases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment