Customizing distribution receipt

[cielf]

Summary

Provide the ability to suppress the value-related columns and the packages column on the "Print Distribution"

Why do this?

Bank request -- according to them "The value per item and in-kind value can be confusing" for their situation.

Details

• Add "hide value columns on receipt" and "hide packages column on receipt" flags on Organization, default to false
• These should be on both edit and show
• When printing the distribution,
  --if the "hide value columns on receipt" field is true, suppress the Value/item and In-Kind Value columns and totals.
  --if the "hide packages column on receipt" filed is true, suppress the Packages column and totals

Criterial for completion

• Tests to support behaviour as described above
• Implement behaviour as described above
• Please include screenshots in your PR

[pshong79]

Hi. I think I would like to try to take this on. However, I won't be able to take this on for a few days. If someone wants to pick this up and get started earlier, please feel free; otherwise, I can pick this up in a few days.

[cielf]

Hey @pshong79, please comment again when you pick it up, then, and we'll officially assign it to you. Thanks!

[pshong79]

As I was thinking about this some last night, I did have a question. Are you thinking one flag for the values columns (hide_value_columns_on_receipt) or do you think it would be worth adding a flag for each (hide_value_per_item_column_on_receipt and hide_in_kind_value column_on_receipt)?

[cielf]

Thanks for asking! I'm pretty sure that the two value items are related -- that the in-kind value is the value per item times the number of items? So I think keeping it as one flag covering both the value columns makes sense.

[nikolaz90]

Hey @pshong79
Did you start working on this one?
Happy to share a PR or let you take it :)

[pshong79]

Hi @nikolaz90! 👋 I have not started this. I just got a new Macbook and am still in the process of getting things back up and running. Feel free to take it if you want!!!

[cielf]

Assigning it to @nikolaz90

[nikolaz90]

Oh cool! Thanks @pshong79 !

[nikolaz90]

Hello @cielf
Quick question, I'm not sure if I've misinterpreted the details.
I started working on check boxes a user would use in next to the print button, screenshots are here
But on rereading, it's not clear if the choices should actually be persisted the organization table.
More than happy to adapt/rework the PR as per.

[cielf]

Hey @nikolaz90 Thanks for checking! This should be an option at the organization level, not the distribution level. Banks will would opt out of those columns once to be applied across all their distributions.

Hope that clears things up!

[nikolaz90]

Hey @cielf, that makes sense and I should have read more carefully.
I'll make the changes accordingly, thanks !

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.