[Refactor] Literal string value of Partner::AGENCY_TYPES["OTHER"] is used in some erb files

[callmarx]

Summary

Working on issue #3067 I've noticed that in some erb files they are checking if agency_type is other with the literal string value instead of Partner::AGENCY_TYPES["OTHER"].

For example, in app/views/profiles/_show.html.erb line 9 we have:

...
    <% if partner_profile.agency_type == "Other" && partner_profile.other_agency_type %>
      (<%= partner_profile.other_agency_type %>)
    <% end %>
...

And this should be:

...
    <% if partner_profile.agency_type == Partner::AGENCY_TYPES["OTHER"] && partner_profile.other_agency_type %>
      (<%= partner_profile.other_agency_type %>)
    <% end %>
...

Things to consider

As I chated on slack with @cielf, this has no urgency at the moment since the odds of Partner::AGENCY_TYPES["OTHER"] changing are low and we also think thats could be a Good First Issue.

Criteria for Completion

No response

[dorner]

Hey @callmarx - after discussion we think there's a better approach to fixing this as documented in #4241. Closing this in favor of that one. Thanks for the suggestion!