Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account requests and org websites #4423

Closed
2 tasks
cielf opened this issue Jun 3, 2024 · 2 comments · Fixed by #4427
Closed
2 tasks

Account requests and org websites #4423

cielf opened this issue Jun 3, 2024 · 2 comments · Fixed by #4427
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 3, 2024

Summary

We insist on http://something.something or https://something.something as the website format when we are creating a new organization. However, we do not insist that the folks enter it that way. So we end up having to change it ourselves almost every time. We need to enforce the format when it is initially entered.

Why change

Save time for the person vetting / creating organizations

Details

We insist on a particular format for the org website ( http://name.suffix or https://name.suffix )when actually creating the organization, but we don;t on account request. However, the form we get is enough to create a link out of.
This slows down the account acceptance process , as the admin has to correct the format.

So, we need to enforce the format for the website in the initial account request form. At the same time, we need to make it clear (provide an example format) that that is the format required, to minimize confusion.

Criteria for completion

  • the website format on initial entry of an account request is constrained to the proper format
  • tests to support this.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jun 3, 2024
@Gabe-Torres
Copy link
Contributor

Gabe-Torres commented Jun 4, 2024

Hey! @cielf I'd love to take this issue.
Would this require adding validation for organization_website within the Account Request model similar to the organization model?

@cielf
Copy link
Collaborator Author

cielf commented Jun 4, 2024

Hey @Gabe-Torres -- It's yours. It looks like we actually don't have any checks on the field at this point -- though I've never run into someone providing nonsense. And yes -- I believe that it will require adding validation on organization_website similar to the organization model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants