Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling old/stale account requests #4514

Closed
2 tasks
cielf opened this issue Jul 14, 2024 · 4 comments · Fixed by #4622
Closed
2 tasks

Handling old/stale account requests #4514

cielf opened this issue Jul 14, 2024 · 4 comments · Fixed by #4622
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

Provide the ability to cleanup old account requests without sending out rejections

Why

The amount of unconfirmed have gotten a little out of hand, plus we have a (currently ongoing) problem where we have had to add some organizations by hand.
#Details

Let's add a new status that will hold this concept of we aren't going on with this for some reason that isn't going to make us send a note out to the user. Let's call it "admin_closed"

"Admin Closed" requests should be in the closed scope (for display purposes)

Provide a button "Close (Admin)" to move a request to the status on each account request that is in Started or User Confirmed status. Allow provision of an optional reason.

This status change should not generate any emails.

Criteria for completion

  • Addition of administrative close functionality as detailed above
  • tests to support this functionality
@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
@manuel1280
Copy link
Contributor

Hi @cielf So I will take this, Can you give me more details about where exactly are the account requests to be rejected? I want to be sure. Thx

@cielf
Copy link
Collaborator Author

cielf commented Aug 27, 2024

sSgn in as superadmin@example.com. Click on Account Requests. I don't think there are any Account Requests in the seed, unfortunately.

So -- to set up an account request, you would (while not logged in) go to the home page and click "register your bank here for free". IIRC there is a step where you confirm that you are a bank rather than a partner, then fill in the form and submit. This will generate an email, which should appear in your browser in a couple of minutes.

At this point the user is an unconfirmed user, and should appear in the Account Requests as such. There is also a link in the email to confirm that you are real. That changes the status on the account request.

I hope that's enough to get you started!

@manuel1280
Copy link
Contributor

Hi @cielf I already have the branch, but I don't know how to create the PR, when I try to push the branch I get this error
'fatal: Authentication failed for 'https://github.com/rubyforgood/human-essentials.git/'', I cloned the project by ssh. can you guide me please

@manuel1280
Copy link
Contributor

manuel1280 commented Aug 30, 2024

Hi @cielf I already have the branch, but I don't know how to create the PR, when I try to push the branch I get this error 'fatal: Authentication failed for 'https://github.com/rubyforgood/human-essentials.git/'', I cloned the project by ssh. can you guide me please

Nevermind, I was doing wrong. The PR is done, I hope everything is ok :) #4622

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants