Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Issue with selecting children for request who are not currently active #4516

Closed
2 tasks
cielf opened this issue Jul 14, 2024 · 2 comments · Fixed by #4699
Closed
2 tasks

[BUG] Issue with selecting children for request who are not currently active #4516

cielf opened this issue Jul 14, 2024 · 2 comments · Fixed by #4699
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 14, 2024

Summary

If you select a child to be in a request, that child's items should be included in the request, whether or not the child is currently designated active.

Why?

We assume the partner knows that the child is receiving items this request, whether or not they are really considered to be active. Perhaps it's a one-off for reasons we don't know, but we wouldn't expect them to be defaulted to getting items next request.

Details

To see this, login in as verified@example.com, and do a child request without changing the selection on any of the children. Then do the same request, but also toggling one of the children who are not currently selected to receive items.
Check the levels on the items that child is slotted to received. Currently, those two requests would have the same amounts. They shouldn't be.

Criteria for completion

  • Requests for all selected children (both active and inactive) are included in the final request
  • Tests to demonstrate that is true.
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Jul 14, 2024
@awwaiid awwaiid modified the milestone: Tasks 2024 Jul 28, 2024
@SansSeryph
Copy link
Contributor

Hello! May I take this issue?

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Sep 28, 2024
@cielf
Copy link
Collaborator Author

cielf commented Sep 28, 2024

Yes you may!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants