Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Kit Redesign] Phase 1 - Change itemizable source #3707

Open
dorner opened this issue Jul 2, 2023 · 4 comments · May be fixed by #3750 or #4560
Open

[Kit Redesign] Phase 1 - Change itemizable source #3707

dorner opened this issue Jul 2, 2023 · 4 comments · May be fixed by #3750 or #4560
Labels
Difficulty—Intermediate

Comments

@dorner
Copy link
Collaborator

dorner commented Jul 2, 2023

Summary

See #3652

  • Add the Itemizable module to the base Item class.
  • Add a migration to change the itemizable_id for all kits' line items to instead point to the kit's item. Back up the DB first!
  • Update views and allocation / deallocation logic to work with the item's line items instead of the kits.

Things to consider

We should probably add a comment to the Itemizable module stressing that it indicates that the parent model has line items, not items.

Criteria for Completion

No response
@zeeshan-haidar
Copy link
Contributor

I can work on this

@dorner dorner mentioned this issue Jul 6, 2023
Closed
2 tasks
@zeeshan-haidar zeeshan-haidar linked a pull request Jul 18, 2023 that will close this issue
Draft
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Aug 6, 2023
@zeeshan-haidar
Copy link
Contributor

This issue depends on this PR to get merge first

@github-actions github-actions bot removed the stale label Aug 7, 2023
@zeeshan-haidar zeeshan-haidar removed their assignment Sep 3, 2023
@jimmyli97
Copy link
Contributor

I think I can do this by cherry-picking commits from #3750 and fixing it up a little

This was referenced Aug 1, 2024
Draft
Open
Open
@jimmyli97 jimmyli97 mentioned this issue Aug 8, 2024
Open
@jimmyli97 jimmyli97 mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty—Intermediate
Projects
None yet
Milestone
No milestone
3 participants
@jimmyli97 @dorner @zeeshan-haidar