-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distribution export -- item columns are no longer in alphbetical order. Fix it. #4593
Comments
I'd like to give this issue a try if no one has taken it yet. |
It's yours! |
so I just found that the item columns are not in alphabetical order since it shows in index page it was ordered by 'issued_at'
my question is, should we also order the items by partner name alphabetically on the index page, or should we keep the current ordering by 'issued_at' there, and only apply alphabetical ordering for the CSV export? Looking forward to your thoughts! Thank you! |
The rows in the distribution index are sorted by issued at, in reverse chronological order, and that's correct. We want to reorder the columns for the items in the export, not the rows. I.e., the columns which correspond to items should appear in lower case alphabetical from left to right. Hope that helps! |
Oh, I got it, so it need to reorder columns for the items like Adult Briefs (Medium/Large), Adult Briefs (Small/Medium), Adult Briefs (XXL), Adult Briefs (XXXL), Adult Briefs (XS/Small) etc alphabetically from left to right, sorry for the misunderstanding earlier 😅 I'll try my best on resolving this accordingly, thank you for your patience! |
Summary
The items columns in the distribution export should be in lower-case alphabetical order.
Why?
Findability and stability.
Details
To recreate, sign in as org_admin1@example.com. Choose Distributions, then click "Export Distributions". If you look at the entire set of columns for the items, you will see that some of them are not in alphabetical order (they're probably in added-to-the-database order).
The columns relating to items should be in lower-case alphabetical order.
Criteria for completion
The text was updated successfully, but these errors were encountered: