-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore disabling InventoryItem #4333
Comments
Started looking at this... there really isn't a way to do this halfway and validate it. A whole crapload of specs fail because they're testing very specific methods or items that won't exist. Basically the end result of this would be a branch where all reference to inventory items and any method that deals with them are completely expunged. One thing that tripped me up is that a bunch of specs do |
Hmm. I'm not sure that I've throughly tested the inventory history feature with event sourcing. I expect we'll need to have it only go back to the snapshot date, yes? |
Yep. We can only show history via events. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
I believe the status on this is that we have determined that we will need the inventoryitem until such time as we don't care about the inventory history before event sourcing. This is estimated to be (hopefully) January 1 2026. Especially as the pre-event sourcing inventory history is suspect, we should be able to get stakeholder buy-in for that. |
We will need InventoryItem, the model, but we should be removing all code that creates, updates or reads them. |
Except for whatever is necessary to use the versions. |
Yup. Just that one place. |
I'm adding a "Waiting for" to the HE Project, and putting in an entry about this dated Jan 1 2026. Closing it as a current issue. |
Summary
When the Event system is fully adopted we'll want to remove InventoryItems altogether. As a step in that direction, for this ticket explore turning InventoryItem writes into a NOP or experimenting with removing it altogether. Then run the tests / interactive in Event mode and see what breaks!
Things to consider
No response
Criteria for Completion
The text was updated successfully, but these errors were encountered: