Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] If you have an error on entering a partner group, the Item Categories changes to a yes/no! Obviously wrong! #4655

Closed
2 tasks
cielf opened this issue Sep 15, 2024 · 2 comments · Fixed by #4668

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 15, 2024

Summary

If you have an error on a partner group, the item categories changes to a yes/no selection. It shouldn't!

Why fix?

Because it's wrong and will be very confusing if it happens in the wild

Details

To Recreate

Sign in as org_admin1@example.com
Left hand menu: Partner Agencies | All Partners.
Choose the "Groups" tab
Note the name of the existing group. (if there isn't one, create one first.)
Click "New Partner Group"
Enter the same name as the existing group
Click "Add Partner Group"
The Item Categories are now showing as "Yes/No".

What should happen?

The Item Categories should still show as the list of item categories .

Criteria for completion.

  • Item categories still show up in the New Partner Group screen after error
  • automated tests to confirm this behaviour.
@victorhwmn
Copy link
Contributor

@cielf Hi! I would like to work on this issue. Could you assign it to me?

@cielf
Copy link
Collaborator Author

cielf commented Sep 19, 2024

It's yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants