Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Printing donation with Product Drive but no Product Drive Participant gives unhandled exception #4818

Closed
2 tasks
cielf opened this issue Dec 1, 2024 · 2 comments · Fixed by #4831
Closed
2 tasks
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Dec 1, 2024

Summary

If you print a donation with a product drive, but no product drive participant, it gives an unhandled exception. It should skip trying to print the product drive participant instead.

Why?

We've got over 3000 of this case in production -- so this is definitely a normal business case.

Details

To replicate

sign in as org_Admin1@example.com
Click Donations
New Donation
enter a donation that has a product drive, but leave the product drive participant blank
save
print
It gives a 500 error

What should happen instead

It looks like this is happening when the "Donation from" section is being printed. If it's a product drive, but without a product drive participant, put "Product Drive -- [the name of the product drive]" there instead.

Hint:

donation_pdf.rb has a class called DonorInfo you should look at.

#Criteria for completion

  • behaviour as described above
  • tests to support the behaviour
@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Dec 1, 2024
@gabeparra01
Copy link
Contributor

Hi, I would like to work on this as my first contribution to this repo. Thanks to the helpful Getting Started docs and the very detailed write up for this issue, I think I have been able to reproduce it locally:
image

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Dec 5, 2024
@cielf
Copy link
Collaborator Author

cielf commented Dec 5, 2024

Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants