Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sprockets from 4.0.3 to 4.2.0 #3405

Closed
wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 24, 2023

Bumps sprockets from 4.0.3 to 4.2.0.

Release notes

Sourced from sprockets's releases.

v4.1.1

  • Fix Sprockets::Server to return response headers to compatible with with Rack::Lint 2.0.

Full Changelog: rails/sprockets@v4.1.0...v4.1.1

v4.1.0

What's Changed

New Contributors

Full Changelog: rails/sprockets@v4.0.3...v4.1.0

Changelog

Sourced from sprockets's changelog.

4.2.0

  • Rack 3 compatibility. #758
  • Fix thread safety of Sprockets::CachedEnvironment and Sprockets::Cache::MemoryStore. #771
  • Add support for Rack 3.0. Headers set by sprockets will now be lower case. #758
  • Make Sprockets::Utils.module_include thread safe on JRuby. #759

4.1.0

  • Allow age to be altered in asset:clean rake task.
  • Fix Sprockets::Server to return lower-cased response headers to comply with Rack::Lint 3.0. #744
  • Adding new directive depend_on_directory #668
  • Fix application/js-sourcemap+json charset #669
  • Fix CachedEnvironment caching nil values #723
  • Process *.jst.ejs.erb files with ERBProcessor #674
  • Fix cache key for coffee script processor to be dependent on the filename #670
Commits
  • eafbd11 Prepare for 4.2.0
  • cce2c0a Merge pull request #771 from eregon/thread-safe-CachedEnvironment
  • 39490de Make the URI tests pass with ruby-head
  • 58eb15d Add TruffleRuby in CI
  • d503c9b Add ChangeLog entry
  • 9d461f1 Make Sprockets::Cache::MemoryStore thread-safe by using a Mutex
  • 4e74e3a Use Concurrent::Map#fetch_or_store
  • 2d454bc Make Sprockets::CachedEnvironment thread-safe by using Concurrent::Map
  • 1276b43 Merge pull request #759 from ntkme/module-include-thread-safety
  • 722d587 Make Sprockets::Utils.module_include thread safe
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 24, 2023
@awwaiid awwaiid requested a review from dorner February 24, 2023 04:38
@awwaiid
Copy link
Collaborator

awwaiid commented Feb 24, 2023

@dorner you had specifically used sprockets 4.0 in a previous PR instead of 4.2 and I didn't know what the reason was. All the tests pass with this at 4.2, I can do some further testing if it would help.

@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.2.0 branch from f5acaba to 4b51cae Compare February 24, 2023 05:03
@dorner
Copy link
Collaborator

dorner commented Feb 28, 2023

@awwaiid it's because of this issue rails/sprockets#749 - it affects development, not any of the other environments.

@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.2.0 branch 2 times, most recently from 78c47e6 to cae9104 Compare March 14, 2023 12:59
@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.2.0 branch from cae9104 to 6d4abc1 Compare March 19, 2023 15:29
Bumps [sprockets](https://github.com/rails/sprockets) from 4.0.3 to 4.2.0.
- [Release notes](https://github.com/rails/sprockets/releases)
- [Changelog](https://github.com/rails/sprockets/blob/main/CHANGELOG.md)
- [Commits](rails/sprockets@v4.0.3...v4.2.0)

---
updated-dependencies:
- dependency-name: sprockets
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.2.0 branch from 6d4abc1 to feca39d Compare March 21, 2023 13:32
@awwaiid
Copy link
Collaborator

awwaiid commented Mar 26, 2023

@dorner Well .... what do you think of this in-code patch to sprockets to work around this? I looked at the upstream sprockets issue and code and didn't see any obvious PR that I should submit there.

@dorner
Copy link
Collaborator

dorner commented Mar 26, 2023

Ouch, that's super hacky. :) I'd much rather get a fix for this on the sprockets side. I'm sure it's possible, it's just not easy to do.

@awwaiid
Copy link
Collaborator

awwaiid commented Apr 1, 2023

I'm going to look into the vendoring work around mentioned in hotwired/stimulus-rails#108

@awwaiid
Copy link
Collaborator

awwaiid commented Jun 25, 2023

One of the upstream projects closed the related bug-report, saying that this isn't an issue with newer rails. I'm not sure if that is really true, but might be worth re-evaluating. Still -- we could vendorize the one file and that might at least get this mergeable.

@dorner
Copy link
Collaborator

dorner commented Jun 30, 2023

I'd rather not monkey patch if there isn't a really good reason. Just tried it with latest Rails and it seems to still be a problem.

@dorner
Copy link
Collaborator

dorner commented Jun 30, 2023

Tried vendoring it as well and it doesn't seem to work either ☹️

@dorner
Copy link
Collaborator

dorner commented Jun 30, 2023

ok, figured it out. No idea why they're saying this isn't happening any more. Wondering if the "stock app" they're testing on has some kind of different setting than ours. I'll put up a PR.

@dorner dorner mentioned this pull request Jun 30, 2023
@dorner
Copy link
Collaborator

dorner commented Jun 30, 2023

Closing in favor of #3704 .

@dorner dorner closed this Jun 30, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 30, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dorner dorner deleted the dependabot/bundler/sprockets-4.2.0 branch June 30, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants