Update user table by removing org information #4453
+8
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Jun 16, 2024
| <%= f.input :organization_id, label: "Organization", wrapper: :input_group, required: true, autofocus: true do %> | ||
| <span class="input-group-text"><%= fa_icon "building" %></span> | ||
| <%= f.input_field :organization_id, collection: @organizations, class: "form-control" %> | ||
| <% end %> |
There was a problem hiding this comment.
The ticket suggested not making changes to New, just Edit.
There was a problem hiding this comment.
This is true. I'm trying to find the issue that past CL failed to link to in this issue. (i.e. why it is a separate thing) (it's still in our backlog, but part of a larger being able to add more types of users -- including superadmins).
New doesn't currently have the role and resource part of the form -- removing the organization without other changes will simply break it.
|
@cancelei are you still planning to finish this up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… admin users list view
Resolves #4296
Description
Type of change
How Has This Been Tested?
Screenshots