Product totals - custom units

[awwaiid]

Implement #4408

• Adds units when feature is enabled and there are any units
• Changes sort to be by name instead of by qty

[awwaiid]

From a production snapshot:

pry(main)> Partners::ItemRequest.where(name: nil).count
  Partners::ItemRequest Count (15.1ms)  SELECT COUNT(*) FROM "item_requests" WHERE "item_requests"."name" IS NULL
=> 0

[cielf]

1/ Could we use the plural for the custom units in this?
2/ We're putting a dash, but no unit when it's that situation where they just have units. maybe we should say "units" there.

[awwaiid]

I'm wondering which is better, Pads - units or Pads. Also ... the way we've implemented units elsewhere end up recording an empty string. We could maybe explicitly record "units" as the individual-units default recorded in the database.

[cielf]

Which is better is a fair question. Is it a Wednesday question?

[dorner]

I'd probably prefer it like this:

• Pads (individual)
• Pads (in packs)

[cielf]

I'd probably prefer it like this:

• Pads (individual)
• Pads (in packs)

I think (in packs) implies the number of pads that happen to be in packs, as opposed to the number of packs. I kind of like the parentheses, though.

This is still the whole naming things issue - but I think we should be consistent between what we use for the partners and what we use for the banks -- because they do have conversations.

How about:

• Pads (units)
• Pads (packs)

I don't like "units", because of the naming conflict with "Custom Request Units" , but it's what we got from the banks. We could check if "pieces" would work for them, maybe?