Fix crash on invalid date object

ext/mini_racer_extension/mini_racer_extension.cc

@@ -586,10 +586,6 @@ static VALUE convert_v8_to_ruby(Isolate* isolate, Local<Context> context,
         return INT2FIX(value->Int32Value(context).ToChecked());
     }
 
-    if (value->IsNumber()) {
-        return rb_float_new(value->NumberValue(context).ToChecked());
-    }
-
     if (value->IsTrue()) {
         return Qtrue;
     }
@@ -598,6 +594,25 @@ static VALUE convert_v8_to_ruby(Isolate* isolate, Local<Context> context,
         return Qfalse;
     }
 
+    struct State {
+        Isolate* isolate;
+        Local<Value> value;
+        Local<Context> context;
+    } state = {isolate, value, context};
+
+    // calls to rb_*() functions can raise exceptions and longjmp,
+    // and therefore must be inside this protected block
+    auto can_raise = [](VALUE arg) -> VALUE {
+        State* state =
+            reinterpret_cast<State*>(static_cast<uintptr_t>(RB_NUM2ULL(arg)));
+        Isolate* isolate = state->isolate;
+        Local<Value> value = state->value;
+        Local<Context> context = state->context;
+
+        if (value->IsNumber()) {
+            return rb_float_new(value->NumberValue(context).ToChecked());
+        }
+
         if (value->IsArray()) {
             VALUE rb_array = rb_ary_new();
             Local<Array> arr = Local<Array>::Cast(value);
@@ -673,6 +688,13 @@ static VALUE convert_v8_to_ruby(Isolate* isolate, Local<Context> context,
             Local<String> rstr = rstr_maybe.ToLocalChecked();
             return rb_utf8_str_new(*String::Utf8Value(isolate, rstr), rstr->Utf8Length(isolate));
         }
+    };
+
+    // this is kind of slow because RB_ULL2NUM allocs when the pointer
+    // doesn't fit in a fixnum but yolo'ing and reinterpret_casting the
+    // pointer to a VALUE is probably not very sound
+    VALUE arg = RB_ULL2NUM(reinterpret_cast<uintptr_t>(&state));
+    return rb_protect(can_raise, arg, nullptr);
 }
 
 static VALUE convert_v8_to_ruby(Isolate* isolate,

test/mini_racer_test.rb

@@ -252,6 +252,16 @@ def test_return_hash
     )
   end
 
+  def test_date_nan
+    # NoMethodError: undefined method `source_location' for "<internal:core>
+    # core/float.rb:114:in `to_i'":Thread::Backtrace::Location
+    if RUBY_ENGINE == "truffleruby"
+      skip "TruffleRuby bug"
+    end
+    context = MiniRacer::Context.new
+    context.eval("new Date(NaN)") # should not crash process
+  end
+
   def test_return_date
     context = MiniRacer::Context.new
     test_time = Time.new