Support prebuilt counter cache association list #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieujobin
approved these changes
Mar 12, 2024
|
Thanks a lot for this fix |
|
Thank you for your fix @JoeDupuis! Given that Rails 7.2 is getting closer to being released, would you be willing to cut a new gem version @mathieujobin with this fix? |
|
Thanks for the reminder @rickychilcott I will release that shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552
Rails 7.2 will remove
each_counter_cached_associationswhich was the hook to bypass incrementing/decrementing the counter.This change overrides the new counter cache list and uses it as the new hook to bypass updating the counter when it is present, else it falls back to the old behavior.