From 373a5112f74a0b60c129a31655cd8f89c4a622b0 Mon Sep 17 00:00:00 2001 From: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Date: Wed, 2 Oct 2024 17:51:52 +0530 Subject: [PATCH 1/3] chore: release 1.35.0 (#5156) --- CHANGELOG.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d6577b39b8..f9e85034d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,38 @@ # Changelog +## [1.35.0](https://github.com/rudderlabs/rudder-server/compare/v1.34.1...v1.35.0) (2024-10-01) + + +### Features + +* add reason for discards [PIPE-1473] ([#5088](https://github.com/rudderlabs/rudder-server/issues/5088)) ([f835aa7](https://github.com/rudderlabs/rudder-server/commit/f835aa7b8d9f207e54ced23665dfee501355741f)) +* bq configurable partitions ([#5133](https://github.com/rudderlabs/rudder-server/issues/5133)) ([9544374](https://github.com/rudderlabs/rudder-server/commit/9544374a35ba877b316ce9e9d1b662fead509466)) +* redshift serverless ([#5144](https://github.com/rudderlabs/rudder-server/issues/5144)) ([e37b0e9](https://github.com/rudderlabs/rudder-server/commit/e37b0e93c277500f81eeef99c2cd37349a2a2159)) + + +### Bug Fixes + +* add messageId, rudderId and type based on new schema ([#5140](https://github.com/rudderlabs/rudder-server/issues/5140)) ([f6f6dfa](https://github.com/rudderlabs/rudder-server/commit/f6f6dfaaace632eb81221cea54b9ecdb187e6eda)) +* remove legacy hosted code which changes connectionToken ([#5126](https://github.com/rudderlabs/rudder-server/issues/5126)) ([100b3d9](https://github.com/rudderlabs/rudder-server/commit/100b3d96c9923d17b5ff7b208067651ea6238c54)) +* wrong filtering while killing dangling connections ([#5142](https://github.com/rudderlabs/rudder-server/issues/5142)) ([0536285](https://github.com/rudderlabs/rudder-server/commit/053628514bf6cbd3726804aa99cd6ce710d46f49)) + + +### Miscellaneous + +* add db.sql stat collector ([#5146](https://github.com/rudderlabs/rudder-server/issues/5146)) ([61e947c](https://github.com/rudderlabs/rudder-server/commit/61e947ceffb58d9ea308187e9f6dd42672f78b72)) +* add gitleaks scan ([#5036](https://github.com/rudderlabs/rudder-server/issues/5036)) ([5bda381](https://github.com/rudderlabs/rudder-server/commit/5bda381a60ac928a92ca17bfbd5461623bb4218c)) +* change scylla strategy to single table ([#5115](https://github.com/rudderlabs/rudder-server/issues/5115)) ([7e56e43](https://github.com/rudderlabs/rudder-server/commit/7e56e437d91c80935f984a2fcd16dcc84d12fa3d)) +* emit event_delivery_time metric at staging file level ([#5136](https://github.com/rudderlabs/rudder-server/issues/5136)) ([23f943e](https://github.com/rudderlabs/rudder-server/commit/23f943e406cb6c3f67ece51bf567b6ff49b2a780)) +* jit secrets ([#4995](https://github.com/rudderlabs/rudder-server/issues/4995)) ([615833e](https://github.com/rudderlabs/rudder-server/commit/615833ea84b0a84e93bd8f269bd438f9e99cf963)) +* no full vacuum for various reports tables ([#5120](https://github.com/rudderlabs/rudder-server/issues/5120)) ([6e8b03e](https://github.com/rudderlabs/rudder-server/commit/6e8b03e00bc432adeac35f50238ba1a3560b88c2)) +* optimise config backend revisionId calls ([#5139](https://github.com/rudderlabs/rudder-server/issues/5139)) ([62143dc](https://github.com/rudderlabs/rudder-server/commit/62143dc5bd94d51cc37e680c3fb3bd9b09624b6f)) +* revert "chore: trim eventNames sent to reporting if length exceeds 50 characters" ([#5155](https://github.com/rudderlabs/rudder-server/issues/5155)) ([17c5ad7](https://github.com/rudderlabs/rudder-server/commit/17c5ad77945de9832d57e152a13d259fc65b9b8c)) +* revert setting max idle connections for jobsdb ([#5151](https://github.com/rudderlabs/rudder-server/issues/5151)) ([ef57540](https://github.com/rudderlabs/rudder-server/commit/ef5754089d45c231995993d354651b8cf0b413dc)) +* schema and record assertions in warehouse integration test ([#5091](https://github.com/rudderlabs/rudder-server/issues/5091)) ([336b876](https://github.com/rudderlabs/rudder-server/commit/336b876f2d5dc334359d99593baa2b9295769541)) +* sync release v1.34.0 to main branch ([#5113](https://github.com/rudderlabs/rudder-server/issues/5113)) ([336b876](https://github.com/rudderlabs/rudder-server/commit/336b876f2d5dc334359d99593baa2b9295769541)) +* trim eventNames sent to reporting if length exceeds 50 characters ([#5138](https://github.com/rudderlabs/rudder-server/issues/5138)) ([33b5f63](https://github.com/rudderlabs/rudder-server/commit/33b5f6341089651ce0599f08c6df9e322146d993)) +* users context traits and populate users fields ([#5135](https://github.com/rudderlabs/rudder-server/issues/5135)) ([243a4a7](https://github.com/rudderlabs/rudder-server/commit/243a4a7be6bce84779d2f5824175dc03b0989456)) + ## [1.34.1](https://github.com/rudderlabs/rudder-server/compare/v1.34.0...v1.34.1) (2024-09-23) From af832599da56dc8831ac759adadb5531513d1492 Mon Sep 17 00:00:00 2001 From: "siddarth.msv" <82795818+Sidddddarth@users.noreply.github.com> Date: Thu, 3 Oct 2024 16:02:09 +0530 Subject: [PATCH 2/3] chore: remove panic on NewDatabaseSQLStats Register from various reports (#5163) --- enterprise/reporting/error_index/error_index_reporting.go | 3 ++- enterprise/reporting/error_reporting.go | 2 +- enterprise/reporting/flusher/factory.go | 3 ++- enterprise/trackedusers/users_reporter.go | 2 +- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/enterprise/reporting/error_index/error_index_reporting.go b/enterprise/reporting/error_index/error_index_reporting.go index 9ac348df88..de10faa6dd 100644 --- a/enterprise/reporting/error_index/error_index_reporting.go +++ b/enterprise/reporting/error_index/error_index_reporting.go @@ -17,6 +17,7 @@ import ( "github.com/rudderlabs/rudder-go-kit/stats" "github.com/rudderlabs/rudder-go-kit/stats/collectors" kitsync "github.com/rudderlabs/rudder-go-kit/sync" + obskit "github.com/rudderlabs/rudder-observability-kit/go/labels" "github.com/rudderlabs/rudder-server/jobsdb" . "github.com/rudderlabs/rudder-server/utils/tx" //nolint:staticcheck @@ -191,7 +192,7 @@ func (eir *ErrorIndexReporter) DatabaseSyncer(c types.SyncerConfig) types.Report } err = eir.statsFactory.RegisterCollector(collectors.NewDatabaseSQLStats("jobsdb-err_idx", dbHandle)) if err != nil { - panic(fmt.Errorf("failed to register collector: %w", err)) + eir.log.Errorn("error registering database sql stats", obskit.Error(err)) } errIndexDB := jobsdb.NewForReadWrite( "err_idx", diff --git a/enterprise/reporting/error_reporting.go b/enterprise/reporting/error_reporting.go index 9860dac82f..43b8d93c39 100644 --- a/enterprise/reporting/error_reporting.go +++ b/enterprise/reporting/error_reporting.go @@ -293,7 +293,7 @@ func (edr *ErrorDetailReporter) migrate(c types.SyncerConfig) (*sql.DB, error) { dbHandle.SetMaxOpenConns(edr.maxOpenConnections) err = edr.stats.RegisterCollector(collectors.NewDatabaseSQLStats("error_detail_reporting", dbHandle)) if err != nil { - return nil, fmt.Errorf("could not register database stats collector: %w", err) + edr.log.Errorn("error registering database sql stats", obskit.Error(err)) } m := &migrator.Migrator{ diff --git a/enterprise/reporting/flusher/factory.go b/enterprise/reporting/flusher/factory.go index 0d3e661672..c7bce860be 100644 --- a/enterprise/reporting/flusher/factory.go +++ b/enterprise/reporting/flusher/factory.go @@ -13,6 +13,7 @@ import ( "github.com/rudderlabs/rudder-go-kit/logger" "github.com/rudderlabs/rudder-go-kit/stats" "github.com/rudderlabs/rudder-go-kit/stats/collectors" + obskit "github.com/rudderlabs/rudder-observability-kit/go/labels" "github.com/rudderlabs/rudder-server/enterprise/reporting/flusher/aggregator" "github.com/rudderlabs/rudder-server/utils/misc" ) @@ -34,7 +35,7 @@ func CreateRunner(ctx context.Context, table string, log logger.Logger, stats st db.SetMaxOpenConns(maxOpenConns) err = stats.RegisterCollector(collectors.NewDatabaseSQLStats(fmt.Sprintf("reporting_flusher_%s", table), db)) if err != nil { - return nil, fmt.Errorf("registering collector: %w", err) + log.Errorn("error registering database sql stats", obskit.Error(err)) } if table == "tracked_users_reports" { diff --git a/enterprise/trackedusers/users_reporter.go b/enterprise/trackedusers/users_reporter.go index 946de1e3db..22876a0090 100644 --- a/enterprise/trackedusers/users_reporter.go +++ b/enterprise/trackedusers/users_reporter.go @@ -88,7 +88,7 @@ func (u *UniqueUsersReporter) MigrateDatabase(dbConn string, conf *config.Config dbHandle.SetMaxOpenConns(1) err = u.stats.RegisterCollector(collectors.NewDatabaseSQLStats("tracked_users_reports", dbHandle)) if err != nil { - return fmt.Errorf("registering collector: %w", err) + u.log.Errorn("error registering database sql stats", obskit.Error(err)) } m := &migrator.Migrator{ From f329d388668cf1b5d191d0989960c2c5517e0a19 Mon Sep 17 00:00:00 2001 From: devops-github-rudderstack <88187154+devops-github-rudderstack@users.noreply.github.com> Date: Thu, 3 Oct 2024 16:46:09 +0530 Subject: [PATCH 3/3] chore: release 1.35.1 (#5164) --- CHANGELOG.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f9e85034d0..fd1b291786 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## [1.35.1](https://github.com/rudderlabs/rudder-server/compare/v1.35.0...v1.35.1) (2024-10-03) + + +### Miscellaneous + +* remove panic on NewDatabaseSQLStats Register from various reports ([#5163](https://github.com/rudderlabs/rudder-server/issues/5163)) ([af83259](https://github.com/rudderlabs/rudder-server/commit/af832599da56dc8831ac759adadb5531513d1492)) + ## [1.35.0](https://github.com/rudderlabs/rudder-server/compare/v1.34.1...v1.35.0) (2024-10-01)