Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unused/obsolete code #2612

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

chandumlg
Copy link
Member

Description

code clean up

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Base: 44.05% // Head: 44.05% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (2052f3f) compared to base (dceaf29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
- Coverage   44.05%   44.05%   -0.01%     
==========================================
  Files         188      187       -1     
  Lines       39269    39255      -14     
==========================================
- Hits        17301    17292       -9     
+ Misses      20861    20857       -4     
+ Partials     1107     1106       -1     
Impacted Files Coverage Δ
jobsdb/unionQuery.go 84.37% <ø> (+0.26%) ⬆️
enterprise/reporting/setup.go 38.09% <0.00%> (-14.29%) ⬇️
utils/httputil/server.go 80.76% <0.00%> (-11.54%) ⬇️
enterprise/reporting/reporting.go 8.33% <0.00%> (-1.44%) ⬇️
services/rsources/handler.go 70.55% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chandumlg chandumlg marked this pull request as ready for review October 26, 2022 03:30
@atzoum atzoum force-pushed the chore.cleanup-unused-code1 branch from 6a358d2 to 2052f3f Compare October 26, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants