Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade GO version to 1.19 #2635

Merged
merged 1 commit into from
Nov 1, 2022
Merged

chore: upgrade GO version to 1.19 #2635

merged 1 commit into from
Nov 1, 2022

Conversation

atzoum
Copy link
Contributor

@atzoum atzoum commented Nov 1, 2022

Description

Upgrading to latest go version

Notion Ticket

Link

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum force-pushed the chore.goUpgrade branch 2 times, most recently from e1781f4 to 99d1c49 Compare November 1, 2022 11:45
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Base: 43.80% // Head: 43.85% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (32540bc) compared to base (4369abf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2635      +/-   ##
==========================================
+ Coverage   43.80%   43.85%   +0.05%     
==========================================
  Files         187      187              
  Lines       40015    40015              
==========================================
+ Hits        17529    17550      +21     
+ Misses      21388    21364      -24     
- Partials     1098     1101       +3     
Impacted Files Coverage Δ
config/backend-config/namespace_config.go 70.83% <0.00%> (-3.13%) ⬇️
services/rsources/handler.go 69.72% <0.00%> (-0.84%) ⬇️
processor/processor.go 72.05% <0.00%> (+0.82%) ⬆️
enterprise/reporting/reporting.go 9.77% <0.00%> (+1.43%) ⬆️
utils/httputil/server.go 92.30% <0.00%> (+11.53%) ⬆️
enterprise/reporting/setup.go 52.38% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@atzoum atzoum marked this pull request as ready for review November 1, 2022 12:17
@atzoum atzoum requested review from lvrach and fracasula November 1, 2022 12:18
Copy link
Member

@lvrach lvrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants