Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reporting pii filter based on config backend #2655

Merged
merged 6 commits into from
Nov 7, 2022

Conversation

chandumlg
Copy link
Member

Description

Added support to filter reporting data based on backend config settings.

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=5accd4e1fbf9480c9102059897e6068b&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 43.66% // Head: 43.78% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (ce60153) compared to base (2f956b7).
Patch coverage: 62.06% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2655      +/-   ##
==========================================
+ Coverage   43.66%   43.78%   +0.11%     
==========================================
  Files         191      191              
  Lines       40483    40502      +19     
==========================================
+ Hits        17677    17733      +56     
+ Misses      21700    21664      -36     
+ Partials     1106     1105       -1     
Impacted Files Coverage Δ
config/backend-config/types.go 0.00% <ø> (ø)
enterprise/reporting/noop.go 0.00% <0.00%> (ø)
enterprise/reporting/reporting.go 15.89% <66.66%> (+7.55%) ⬆️
processor/processor.go 72.04% <0.00%> (+0.82%) ⬆️
services/rsources/handler.go 71.11% <0.00%> (+1.38%) ⬆️
services/stats/stats.go 90.30% <0.00%> (+1.81%) ⬆️
enterprise/reporting/setup.go 71.42% <0.00%> (+14.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

enterprise/reporting/reporting.go Outdated Show resolved Hide resolved
enterprise/reporting/reporting.go Show resolved Hide resolved
enterprise/reporting/reporting.go Show resolved Hide resolved
@BonapartePC BonapartePC force-pushed the feat.reporting-pii-filter branch from ecda484 to ce60153 Compare November 7, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants