Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use enterprise token from env as fallback #2667

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

chandumlg
Copy link
Member

Description

Falling back to enterprise token read from env (if not provided as an ldflag)

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

runner/runner.go Outdated Show resolved Hide resolved
@atzoum
Copy link
Contributor

atzoum commented Nov 8, 2022

@chandumlg is this change needed for 1.3.0? If so, please change the target to release/1.3.x branch

@chandumlg chandumlg changed the base branch from master to release/1.3.x November 8, 2022 08:23
@chandumlg chandumlg requested a review from BonapartePC November 8, 2022 08:24
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 45.60% // Head: 45.45% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (30edaec) compared to base (0d061ff).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/1.3.x    #2667      +/-   ##
=================================================
- Coverage          45.60%   45.45%   -0.15%     
=================================================
  Files                287      287              
  Lines              47790    47790              
=================================================
- Hits               21793    21722      -71     
- Misses             24619    24691      +72     
+ Partials            1378     1377       -1     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
processor/stash/stash.go 41.56% <0.00%> (-24.28%) ⬇️
services/rsources/handler.go 70.83% <0.00%> (-1.39%) ⬇️
jobsdb/backup.go 76.30% <0.00%> (-0.35%) ⬇️
jobsdb/jobsdb.go 73.39% <0.00%> (-0.30%) ⬇️
router/router.go 74.04% <0.00%> (+0.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cisse21 cisse21 merged commit 56f0f23 into release/1.3.x Nov 8, 2022
@cisse21 cisse21 deleted the fix.detach-enterprise-token-from-releaseinfo branch November 8, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants