chore: data residency adaptations #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 45.49% // Head: 45.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2703 +/- ##
==========================================
- Coverage 45.49% 45.48% -0.02%
==========================================
Files 290 290
Lines 48028 48045 +17
==========================================
+ Hits 21850 21851 +1
- Misses 24797 24809 +12
- Partials 1381 1385 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
atzoum
force-pushed
the
chore.dataResidencyAdaptations
branch
from
2c4345c to
9e0fe8e
Compare
atzoum
changed the title
achettyiitr
approved these changes
Nov 15, 2022
atzoum
changed the title
atzoum
force-pushed
the
chore.dataResidencyAdaptations
branch
from
9e0fe8e to
3774a80
Compare
atzoum
force-pushed
the
chore.dataResidencyAdaptations
branch
from
3774a80 to
82a017f
Compare
cisse21
approved these changes
Nov 17, 2022
chandumlg
reviewed
Nov 18, 2022
| @@ -303,11 +305,12 @@ func newForDeployment(deploymentType deployment.Type, configEnvHandler types.Con | |||
| // Setup backend config | |||
| func Setup(configEnvHandler types.ConfigEnvI) (err error) { | |||
| deploymentType, err := deployment.GetFromEnv() | |||
| region := config.GetString("region", "") | |||
There was a problem hiding this comment.
It would be good, if this line is below err check line.
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With data residency, multiple data planes can exist for the same namespace/workspace in different regions. Each data plane will operate against a region-specific configuration and warehouse nodes need to advertise their region to cp-router, so that control plane can perform cp-router requests targeting a specific region.
According to the above, the following
rudder-serveradaptations are required:regionquery parameter when requesting the configuration from config backend.regionlabel in cp-router's authentication response.Relevant work
#70 adds support for labels and label-based selection of connections in
cp-router.Notion Ticket
Link
Security