Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aws role session name #2712

Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix: aws role session name #2712

merged 1 commit into from
Nov 17, 2022

Conversation

koladilip
Copy link
Contributor

Description

AWS role session name should not contain any spaces so replacing space with hyphen.

Notion Ticket

https://www.notion.so/rudderstacks/Add-AWS-IAM-role-option-for-S3-Lambda-Eventbridge-Kinesis-Firehose-Personalize-destinations-b67c98e8425f4ef8b1b6b906fff08484

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

AWS role session name should not contain any spaces so replacing
space with hyphen.
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 45.51% // Head: 45.48% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (1e2ca7a) compared to base (d01f98b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2712      +/-   ##
==========================================
- Coverage   45.51%   45.48%   -0.03%     
==========================================
  Files         289      289              
  Lines       48007    48007              
==========================================
- Hits        21852    21838      -14     
- Misses      24775    24785      +10     
- Partials     1380     1384       +4     
Impacted Files Coverage Δ
processor/stash/stash.go 44.56% <100.00%> (ø)
utils/awsutils/session.go 96.66% <100.00%> (ø)
services/rsources/handler.go 70.83% <0.00%> (-0.84%) ⬇️
processor/processor.go 85.99% <0.00%> (-0.42%) ⬇️
router/router.go 73.80% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants