fix(destination): delete users support add test-cases and better error strings #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 24, 2022 09:06
- update error message to include actual response - update naming - making maxRetryAttempts as configurable - include jobId in logs
# Conflicts: # regulation-worker/internal/delete/api/api.go
Codecov ReportBase: 46.89% // Head: 46.75% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2744 +/- ##
==========================================
- Coverage 46.89% 46.75% -0.15%
==========================================
Files 300 300
Lines 49101 49111 +10
==========================================
- Hits 23027 22960 -67
- Misses 24609 24686 +77
Partials 1465 1465
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sanpj2292
changed the title
sanpj2292
changed the title
sanpj2292
changed the title
sanpj2292
changed the title
sanpj2292
changed the title
saikumarrs
approved these changes
Nov 30, 2022
atzoum
reviewed
Nov 30, 2022
added 3 commits
November 30, 2022 15:16
…modify test-cases - clarity in error message
atzoum
reviewed
Nov 30, 2022
…ication condition
atzoum
approved these changes
Nov 30, 2022
This was referenced Dec 1, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notion Ticket
https://www.notion.so/rudderstacks/Integrate-OAuth-in-regulation-worker-module-of-server-to-support-GA-dae0cf6ef89e41eb91e9212ac524cf49
Security