Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set max connections to readonly jobsdbs #2745

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

chandumlg
Copy link
Member

Description

Set max connections to readonly jobsdbs to prevent exhausting all the available connections.

Notion Ticket

https://www.notion.so/rudderstacks/8aac9087df644365acdf64e28e290153?v=6e06b0a5ade24f0aa5ffe05dc2972e84&p=a0094efc17da43c1a552d5ab636aa4a9&pm=s

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

jobsdb/readonly_jobsdb.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 46.89% // Head: 46.88% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (b31ba9a) compared to base (4e8df6f).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2745      +/-   ##
==========================================
- Coverage   46.89%   46.88%   -0.02%     
==========================================
  Files         300      300              
  Lines       49099    49101       +2     
==========================================
- Hits        23027    23023       -4     
- Misses      24607    24612       +5     
- Partials     1465     1466       +1     
Impacted Files Coverage Δ
jobsdb/readonly_jobsdb.go 34.20% <66.66%> (+0.23%) ⬆️
services/db/recovery.go 54.76% <0.00%> (-1.20%) ⬇️
processor/processor.go 85.99% <0.00%> (-0.42%) ⬇️
router/manager/manager.go 100.00% <0.00%> (+3.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chandumlg chandumlg merged commit 5e8f73d into master Nov 29, 2022
@chandumlg chandumlg deleted the chore.readonly-jobsdb-maxconnections branch November 29, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants