Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable user deletion for supported destinations #3946

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Oct 6, 2023

Description

  • This pr enables user deletion for iterable destination
  • user deletion changes for transformer is already released, adding destination name to supportedDestinations list is pending, which is what this pr addresses

Linear Ticket

https://linear.app/rudderstack/issue/INT-607/iterable-destination-user-delete-support

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@mihir-4116 mihir-4116 changed the title chore: enable user deletion for iterable destination chore: enable user deletion for supported destinations Oct 6, 2023
@mihir-4116 mihir-4116 requested a review from ItsSudip October 6, 2023 10:56
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dbd4ea6) 70.49% compared to head (e592f00) 70.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3946      +/-   ##
==========================================
- Coverage   70.49%   70.35%   -0.14%     
==========================================
  Files         357      357              
  Lines       53627    53627              
==========================================
- Hits        37803    37729      -74     
- Misses      13569    13630      +61     
- Partials     2255     2268      +13     
Files Coverage Δ
regulation-worker/internal/delete/api/api.go 65.30% <ø> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir-4116 mihir-4116 merged commit 6ceb4e5 into master Oct 9, 2023
@mihir-4116 mihir-4116 deleted the chore.enable-iterable-user-deletion branch October 9, 2023 05:26
@mihir-4116 mihir-4116 changed the title chore: enable user deletion for supported destinations chore(INT-607): enable user deletion for supported destinations Oct 9, 2023
@mihir-4116 mihir-4116 changed the title chore(INT-607): enable user deletion for supported destinations chore: enable user deletion for supported destinations Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants