fix: revert fixes for access_denied error handling for OAuth destinations (#3853) #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 0d30d3b.
sanpj2292
requested review from
fracasula,
krishna2020,
koladilip and
ItsSudip
fracasula
approved these changes
Oct 10, 2023
sanpj2292
changed the title
sanpj2292
changed the title
sanpj2292
changed the title
atzoum
approved these changes
Oct 10, 2023
lvrach
approved these changes
Oct 10, 2023
It was an unexpected one not an afterthought but will keep it in-mind |
I think what @atzoum meant was to test it on dev before merging. As an alternative there is the "Do not merge" labels if someone wants to ask for review but has not tested it fully. |
This was referenced Oct 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 0d30d3b.
Reverting due to minor issues found while testing.
Linear Ticket
https://linear.app/rudderstack/issue/INT-367/testing-review-and-release
Security