chore: remove bugsnag #5014

lvrach · 2024-08-20T11:05:58Z

Description

Remove bugsnag from rudder-server, capturing panics using logs instead.

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1435/remove-bug-snag

Resolves PIPE-1435
Resolves PIPE-611

Security

The code changed/added as part of this pull request won't create any security issues with how the software is being used.

coderabbitai · 2024-08-20T11:06:16Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

utils/crash/noop.go

utils/crash/logger.go

…re.rm-bugsnag

codecov · 2024-08-27T15:44:00Z

Codecov Report

Attention: Patch coverage is 94.05941% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (c18669b) to head (f7ca33a).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
app/apphandlers/processorAppHandler.go	0.00%	4 Missing ⚠️
router/batchrouter/handle_lifecycle.go	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5014      +/-   ##
==========================================
+ Coverage   74.65%   74.79%   +0.13%     
==========================================
  Files         430      433       +3     
  Lines       50144    50149       +5     
==========================================
+ Hits        37436    37508      +72     
+ Misses      10230    10169      -61     
+ Partials     2478     2472       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…re.rm-bugsnag

fracasula

Approved with minor comments 👍

utils/crash/default.go

fracasula · 2024-08-28T17:24:54Z

rruntime/goroutine-factory.go

 		function()
 	}()
 }

 func GoForWarehouse(function func()) {
 	go func() {
-		ctx := bugsnag.StartSession(context.Background())
-		defer misc.BugsnagNotify(ctx, "Warehouse")()
+		defer crash.Notify("Warehouse")()


Can't we use the wrapper here? Same for Core.

The wrapper requires a diffrent signature for function, func() error.

…re.rm-bugsnag

chore: remove bugsnag

cd874ca

$fracasula$

fracasula reviewed Aug 20, 2024

View reviewed changes

utils/crash/noop.go Outdated Show resolved Hide resolved

$fracasula$

fracasula reviewed Aug 20, 2024

View reviewed changes

utils/crash/logger.go Outdated Show resolved Hide resolved

achettyiitr reviewed Aug 20, 2024

View reviewed changes

utils/crash/logger.go Outdated Show resolved Hide resolved

lvrach added 3 commits August 20, 2024 14:23

add test and http handler

e0c8386

add handler

89cfe29

pr fixes

92d01b7

lvrach marked this pull request as ready for review August 22, 2024 12:10

achettyiitr reviewed Aug 27, 2024

View reviewed changes

utils/crash/logger.go Outdated Show resolved Hide resolved

Merge branch 'master' of github.com:rudderlabs/rudder-server into cho…

8b04c61

…re.rm-bugsnag

lvrach requested review from fracasula and achettyiitr August 27, 2024 13:05

use sugar free logger

836f359

lvrach force-pushed the chore.rm-bugsnag branch from 7d21676 to 836f359 Compare August 27, 2024 13:21

achettyiitr approved these changes Aug 27, 2024

View reviewed changes

Merge branch 'master' of github.com:rudderlabs/rudder-server into cho…

06fb63b

…re.rm-bugsnag

$fracasula$

fracasula approved these changes Aug 28, 2024

View reviewed changes

lvrach added 2 commits August 29, 2024 15:27

pr fixes

5aeecaa

Merge branch 'master' of github.com:rudderlabs/rudder-server into cho…

f7ca33a

…re.rm-bugsnag

lvrach enabled auto-merge (squash) August 29, 2024 13:35

lvrach merged commit d68ceb3 into master Aug 29, 2024
53 checks passed

lvrach deleted the chore.rm-bugsnag branch August 29, 2024 13:52

This was referenced Sep 2, 2024

chore: release 1.33.0 #5047

Merged

chore: prerelease 1.33.0-rc.1 #5048

Merged

This was referenced Sep 16, 2024

chore: release 1.33.0 #5093

Closed

chore: prerelease 1.34.0-rc.1 #5094

Closed

chore: release 1.33.0 #5095

Closed

chore: release 1.33.0 #5096

Closed

This was referenced Sep 16, 2024

chore: release 1.33.0 #5097

Closed

chore: release 1.33.0 #5098

Closed

chore: release 1.33.0 #5099

Closed

chore: release 1.33.0 #5100

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove bugsnag #5014

chore: remove bugsnag #5014

lvrach commented Aug 20, 2024 •

edited

Loading

coderabbitai bot commented Aug 20, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Aug 27, 2024 •

edited

Loading

$@fracasula$ fracasula left a comment

$@fracasula$ fracasula Aug 28, 2024 •

edited

Loading

lvrach Aug 29, 2024

chore: remove bugsnag #5014

chore: remove bugsnag #5014

Conversation

lvrach commented Aug 20, 2024 • edited Loading

Description

Linear Ticket

Security

coderabbitai bot commented Aug 20, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Aug 27, 2024 • edited Loading

Codecov Report

fracasula left a comment

Choose a reason for hiding this comment

fracasula Aug 28, 2024 • edited Loading

Choose a reason for hiding this comment

lvrach Aug 29, 2024

Choose a reason for hiding this comment

lvrach commented Aug 20, 2024 •

edited

Loading

coderabbitai bot commented Aug 20, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 27, 2024 •

edited

Loading

$@fracasula$ fracasula left a comment

$@fracasula$ fracasula Aug 28, 2024 •

edited

Loading