-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: webhook integration tests #5061
Conversation
Webhook failures are written to errors table after responding to webhook request and we were checking immediately in errors table that is causing some issues so added retry loop in integration tests.
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5061 +/- ##
==========================================
+ Coverage 74.67% 74.70% +0.02%
==========================================
Files 435 435
Lines 50414 50414
==========================================
+ Hits 37645 37660 +15
+ Misses 10287 10275 -12
+ Partials 2482 2479 -3 ☔ View full report in Codecov by Sentry. |
Description
After responding to the webhook request, webhook failures are written to the errors table. We were checking immediately in the errors table that was causing some issues, so we added a retry loop in integration tests.
Linear Ticket
https://linear.app/rudderstack/issue/PRI-4/webhook-integration-tests
Security