-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: no full vacuum for various reports tables #5120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we potentially have this as a feature flag so that we can specify the type of vacuum we want?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
==========================================
- Coverage 74.80% 73.03% -1.77%
==========================================
Files 435 437 +2
Lines 50436 50898 +462
==========================================
- Hits 37728 37173 -555
- Misses 10241 11299 +1058
+ Partials 2467 2426 -41 ☔ View full report in Codecov by Sentry. |
Description
vacuum
instead ofvacuum full
for various reports tables. This only takes lenient locking and doesn't disrupt other reads/writes to the tables. And while it doesn't free up disk space, it makes the space available for newer tuples added to the table.Having done all this, the table size might still grow, but not at the rate when there was no vacuum at all. Each server startup would help free up disk space.
Linear Ticket
Resolves PIPE-1517
Security