Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add messageId, rudderId and type based on new schema #5140

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

BonapartePC
Copy link
Contributor

@BonapartePC BonapartePC commented Sep 27, 2024

Description

add messageId, rudderId and request type based on new rudder schema in the internal batch endpoint.

Related PRs:
rudderlabs/rudder-schemas#35
https://github.com/rudderlabs/rudder-ingestion-svc/pull/234
https://github.com/rudderlabs/rudder-src-router/pull/144

Linear Ticket

Fixes PIPE-1557

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@BonapartePC BonapartePC force-pushed the fix.cleanupMessageProperties branch from ca7caad to 7601eb5 Compare September 27, 2024 01:45
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 56.52174% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.93%. Comparing base (23f943e) to head (71fb0cb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
gateway/handle.go 56.52% 15 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5140      +/-   ##
==========================================
- Coverage   72.95%   72.93%   -0.02%     
==========================================
  Files         438      438              
  Lines       50911    50951      +40     
==========================================
+ Hits        37141    37160      +19     
- Misses      11337    11354      +17     
- Partials     2433     2437       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gateway/handle.go Outdated Show resolved Hide resolved
gateway/handle.go Outdated Show resolved Hide resolved
gateway/gateway_test.go Show resolved Hide resolved
gateway/gateway_test.go Outdated Show resolved Hide resolved
gateway/gateway_test.go Show resolved Hide resolved
@BonapartePC BonapartePC enabled auto-merge (squash) September 30, 2024 07:17
@BonapartePC BonapartePC enabled auto-merge (squash) September 30, 2024 07:27
@BonapartePC BonapartePC merged commit f6f6dfa into master Sep 30, 2024
52 of 54 checks passed
@BonapartePC BonapartePC deleted the fix.cleanupMessageProperties branch September 30, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants