-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add messageId, rudderId and type based on new schema #5140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BonapartePC
force-pushed
the
fix.cleanupMessageProperties
branch
from
September 27, 2024 01:45
ca7caad
to
7601eb5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5140 +/- ##
==========================================
- Coverage 72.95% 72.93% -0.02%
==========================================
Files 438 438
Lines 50911 50951 +40
==========================================
+ Hits 37141 37160 +19
- Misses 11337 11354 +17
- Partials 2433 2437 +4 ☔ View full report in Codecov by Sentry. |
Sidddddarth
approved these changes
Sep 27, 2024
fracasula
requested changes
Sep 27, 2024
ktgowtham
approved these changes
Sep 30, 2024
fracasula
approved these changes
Sep 30, 2024
This was referenced Sep 30, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add messageId, rudderId and request type based on new rudder schema in the internal batch endpoint.
Related PRs:
rudderlabs/rudder-schemas#35
https://github.com/rudderlabs/rudder-ingestion-svc/pull/234
https://github.com/rudderlabs/rudder-src-router/pull/144
Linear Ticket
Fixes PIPE-1557
Security