Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove panic on NewDatabaseSQLStats Register from various reports #5163

Conversation

Sidddddarth
Copy link
Member

Description

remove panic on NewDatabaseSQLStats Register from various reports

Linear Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Sidddddarth Sidddddarth merged commit af83259 into release/1.35.x Oct 3, 2024
55 checks passed
@Sidddddarth Sidddddarth deleted the chore.removeNewDatabaseSQLStatsRegisterPanicFromEnterprise branch October 3, 2024 10:32
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.89%. Comparing base (373a511) to head (a65a74f).
Report is 1 commits behind head on release/1.35.x.

Files with missing lines Patch % Lines
...ise/reporting/error_index/error_index_reporting.go 0.00% 1 Missing ⚠️
enterprise/reporting/error_reporting.go 0.00% 1 Missing ⚠️
enterprise/reporting/flusher/factory.go 0.00% 1 Missing ⚠️
enterprise/trackedusers/users_reporter.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.35.x    #5163      +/-   ##
==================================================
- Coverage           72.99%   72.89%   -0.11%     
==================================================
  Files                 439      439              
  Lines               51165    51165              
==================================================
- Hits                37350    37295      -55     
- Misses              11361    11411      +50     
- Partials             2454     2459       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants