Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change retl check to source category #5167

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 4, 2024

Description

Replace the check for validating an rETL event from comparing sourceJobRunId(which can also appear in a replay) to sourceCategory

Linear Ticket

Fixes PIPE-1606

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 marked this pull request as ready for review October 4, 2024 06:48
@cisse21 cisse21 merged commit 3ed1302 into release/1.35.x Oct 4, 2024
56 checks passed
@cisse21 cisse21 deleted the chore.replayHotFix branch October 4, 2024 06:55
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.90%. Comparing base (f329d38) to head (72d5bce).
Report is 1 commits behind head on release/1.35.x.

Files with missing lines Patch % Lines
router/worker.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.35.x    #5167      +/-   ##
==================================================
- Coverage           72.90%   72.90%   -0.01%     
==================================================
  Files                 439      439              
  Lines               51165    51165              
==================================================
- Hits                37304    37301       -3     
- Misses              11405    11407       +2     
- Partials             2456     2457       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants