Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add stats to dedup module #5190

Merged
merged 2 commits into from
Oct 14, 2024
Merged

chore: add stats to dedup module #5190

merged 2 commits into from
Oct 14, 2024

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Oct 14, 2024

Description

Adding time stats to dedup module

Linear Ticket

Fixes PIPE-1626

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

mihir20
mihir20 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment regarding metric naming else LGTM

services/dedup/badger/badger.go Outdated Show resolved Hide resolved
services/dedup/badger/badger.go Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the chore.addStatsToDedupModule branch from 24de4e6 to 78aa028 Compare October 14, 2024 05:27
achettyiitr
achettyiitr approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@achettyiitr achettyiitr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. We can leevrage RecordDuration.

services/dedup/mirrorScylla/mirrorScylla.go Outdated Show resolved Hide resolved
@cisse21 cisse21 force-pushed the chore.addStatsToDedupModule branch from 78aa028 to 9ce3a70 Compare October 14, 2024 05:45
@cisse21 cisse21 force-pushed the chore.addStatsToDedupModule branch from 9ce3a70 to 6e22f97 Compare October 14, 2024 07:12
@cisse21 cisse21 enabled auto-merge (squash) October 14, 2024 07:13
@cisse21 cisse21 force-pushed the chore.addStatsToDedupModule branch from 043e83f to 5ea87dd Compare October 14, 2024 08:54
@cisse21 cisse21 merged commit f305282 into master Oct 14, 2024
53 checks passed
@cisse21 cisse21 deleted the chore.addStatsToDedupModule branch October 14, 2024 09:32
@codecov Codecov
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.14%. Comparing base (0e44f18) to head (5ea87dd).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
services/dedup/badger/badger.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5190      +/-   ##
==========================================
- Coverage   73.23%   73.14%   -0.09%     
==========================================
  Files         439      439              
  Lines       51234    51238       +4     
==========================================
- Hits        37520    37477      -43     
- Misses      11283    11311      +28     
- Partials     2431     2450      +19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Oct 14, 2024
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir20 mihir20 mihir20 approved these changes

@achettyiitr achettyiitr achettyiitr approved these changes

@ktgowtham ktgowtham ktgowtham approved these changes

@lvrach lvrach lvrach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cisse21 @lvrach @ktgowtham @mihir20 @achettyiitr