Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aggregate reports based on the configured interval before sending to reporting #5326

Conversation

itsmihir
Copy link
Contributor

@itsmihir itsmihir commented Nov 27, 2024

Description

Currently, the Rudder Server aggregates reports every minute and then flushes them to the Reporting Service. We want to make the aggregation interval configurable, allowing reports to be aggregated over a specified time period, such as 2 minutes instead of the default 1 minute.

Linear Ticket

https://linear.app/rudderstack/issue/OBS-415/support-aggregation-time-as-a-configuration-on-rudder-server-ability

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@itsmihir itsmihir marked this pull request as draft November 27, 2024 11:46
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 91.42857% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.74%. Comparing base (8bbb818) to head (11ee199).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
enterprise/reporting/reporting.go 91.42% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5326      +/-   ##
==========================================
- Coverage   74.76%   74.74%   -0.03%     
==========================================
  Files         433      433              
  Lines       60951    60979      +28     
==========================================
+ Hits        45573    45581       +8     
- Misses      12849    12863      +14     
- Partials     2529     2535       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@itsmihir itsmihir marked this pull request as ready for review November 27, 2024 12:51
@itsmihir itsmihir changed the base branch from master to feat.reports-bactching November 28, 2024 06:01
@ktgowtham ktgowtham requested a review from mihir20 November 29, 2024 06:53
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

enterprise/reporting/reporting.go Show resolved Hide resolved
enterprise/reporting/reporting.go Outdated Show resolved Hide resolved
Base automatically changed from feat.reports-bactching to master December 5, 2024 13:06
@itsmihir itsmihir requested a review from mihir20 December 6, 2024 07:18
@itsmihir itsmihir requested a review from mihir20 December 6, 2024 08:08
@itsmihir itsmihir merged commit 7262975 into master Dec 6, 2024
58 checks passed
@itsmihir itsmihir deleted the feature/obs-415-support-aggregation-time-as-a-configuration-on-rudder-server branch December 6, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants