Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: snowpipe http compression for insert request #5337

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Dec 4, 2024

Description

  • Add support for making gzipped Insert requests to the Snowpipe client,

Linear Ticket

  • Resolves PIPE-1765

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr requested a review from mihir20 December 4, 2024 12:37
@achettyiitr achettyiitr force-pushed the feat.snowpipe-http-compression branch 2 times, most recently from e4f4426 to c02f2a3 Compare December 4, 2024 12:43
@achettyiitr achettyiitr requested a review from koladilip December 4, 2024 12:44
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.86%. Comparing base (33e9915) to head (375113c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ationmanager/snowpipestreaming/internal/api/api.go 77.50% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5337      +/-   ##
==========================================
+ Coverage   74.76%   74.86%   +0.10%     
==========================================
  Files         433      433              
  Lines       60918    60954      +36     
==========================================
+ Hits        45544    45633      +89     
+ Misses      12855    12804      -51     
+ Partials     2519     2517       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the feat.snowpipe-http-compression branch from c02f2a3 to b041dd4 Compare December 5, 2024 07:55
@achettyiitr achettyiitr requested a review from koladilip December 5, 2024 07:56
@achettyiitr achettyiitr force-pushed the feat.snowpipe-http-compression branch 2 times, most recently from 86c4aa7 to 7c9db1b Compare December 5, 2024 08:12
@achettyiitr achettyiitr force-pushed the feat.snowpipe-http-compression branch from 7c9db1b to a14f4b8 Compare December 5, 2024 08:33
@achettyiitr achettyiitr requested a review from mihir20 December 5, 2024 10:51
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achettyiitr achettyiitr force-pushed the feat.snowpipe-http-compression branch from a14f4b8 to e109ea7 Compare December 5, 2024 12:58
@achettyiitr achettyiitr merged commit 232b107 into master Dec 5, 2024
58 checks passed
@achettyiitr achettyiitr deleted the feat.snowpipe-http-compression branch December 5, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants