Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reporting type status detail #5345

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Conversation

koladilip
Copy link
Contributor

Description

StatTags was added to the StatusDetail type for category computation but it was getting propagated to reporting API and causing some validation to fail.

Linear Ticket

https://linear.app/rudderstack/issue/INT-2973/[chore]-propagate-error-category-from-stattags-of-transformer
Resolves INT-2973

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.76%. Comparing base (232b107) to head (84f8477).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5345      +/-   ##
==========================================
- Coverage   74.77%   74.76%   -0.01%     
==========================================
  Files         433      433              
  Lines       60954    60954              
==========================================
- Hits        45578    45573       -5     
+ Misses      12856    12850       -6     
- Partials     2520     2531      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip koladilip requested a review from cisse21 December 6, 2024 06:52
@koladilip koladilip merged commit 8bbb818 into master Dec 6, 2024
58 checks passed
@koladilip koladilip deleted the fix/type-struct-status-detail branch December 6, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants