fix: reports aggregation query to select sample_event and sample_response correctly #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishrudderstack
approved these changes
Dec 10, 2024
vamsikrishnakandi
approved these changes
Dec 10, 2024
itsmihir
changed the base branch from
prerelease/1.39.0-rc.1
to
release/1.39.x
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/1.39.x #5360 +/- ##
==================================================
+ Coverage 74.75% 74.81% +0.06%
==================================================
Files 437 437
Lines 61240 61240
==================================================
+ Hits 45777 45819 +42
+ Misses 12925 12881 -44
- Partials 2538 2540 +2 ☔ View full report in Codecov by Sentry. |
This was referenced Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For warehouse module sample event will always be empty, we need to update the FILTER on ARRAY_AGG in reporting reports aggregation query to select samples response even if sample event is empty.
Linear Ticket
Resolves OBS-732
OBS-732: Fix reports aggregation query on rudder-server to handle empty sample event
Security