Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: processing pickup race condition #5374

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Dec 16, 2024

Description

  • There is a race condition happening, when the upload job is getting picked up, at the same time while trying to create new jobs, we are checking if there are some waiting jobs present. If present, we are deleting those.

Linear Ticket

  • Resolves WAR-123

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr force-pushed the fix.processing-pickup-race-condition branch from 25b87a6 to 2ac9a49 Compare December 16, 2024 10:22
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (aef8585) to head (5e40fa6).
Report is 1 commits behind head on release/1.39.x.

Files with missing lines Patch % Lines
warehouse/router/router.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release/1.39.x    #5374   +/-   ##
===============================================
  Coverage           74.81%   74.82%           
===============================================
  Files                 437      437           
  Lines               61240    61249    +9     
===============================================
+ Hits                45816    45827   +11     
+ Misses              12896    12882   -14     
- Partials             2528     2540   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cisse21 cisse21 force-pushed the fix.processing-pickup-race-condition branch from 2ac9a49 to 5e40fa6 Compare December 17, 2024 04:35
@cisse21 cisse21 merged commit 21f0d13 into release/1.39.x Dec 17, 2024
56 checks passed
@cisse21 cisse21 deleted the fix.processing-pickup-race-condition branch December 17, 2024 04:58
mihir20 added a commit that referenced this pull request Dec 20, 2024
* fix: processing pickup race condition (#5374)

* chore: release 1.39.1 (#5376)

* chore: add error msg in the logs when gw req fails (#5369)

* chore: add error msg in the logs when gw req fails

* addressed comments

* addressed comments

* update go version and schema version

* update go version in docker file

* downgrade swagger-editor-validate

* update action to apidom-validate

* chore: release 1.39.2 (#5382)

---------

Co-authored-by: Akash Chetty <achetty.iitr@gmail.com>
Co-authored-by: Mihir Gandhi <mihir20121997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants