Choice fields with hyphens result in dashes in enum values

[PeterJCLaw]

For example:

"shipping_method": {
	"enum": [
		"fedex",
		"dhl",
		"royal-mail",
		"carrier-pigeon"
	],
	"type": [
		"string"
	]
},

Results in:

/**
 * This client was automatically generated by RudderTyper. ** Do Not Edit **
 */
package com.rudderstack.ruddertyper.generated;


public enum ShippingMethod {

    S_FEDEX("fedex"),
    S_DHL("dhl"),
    S_ROYAL-MAIL("royal-mail"),
    S_CARRIER-PIGEON("carrier-pigeon");

    private final Object value;

    ShippingMethod(Object value) {
        this.value = value;
    }

    public Object getValue() {
        return value;
    }
}

This appears to affect at least the Java and TypeScript generators.

[contributor-support]

Thanks for opening this issue! We'll get back to you shortly. If it is a bug, please make sure to add steps to reproduce the issue.

[TWiStErRob]

This line is preparing the name (Java):

rudder-typer/src/generators/android/android.ts

Line 167 in 921f5e4

key = 'S_' + value.toString().trim().toUpperCase().replace(/ /g, '');

it only removes "space" as invalid characters, it should probably remove everything that's invalid according to

rudder-typer/src/generators/android/android.ts

Lines 60 to 61 in 921f5e4

	allowedIdentifierStartingChars: 'A-Za-z_',
	allowedIdentifierChars: 'A-Za-z0-9_',

[PeterJCLaw]

IMO it would be nice to replace any (string of) invalid characters with _ rather than dropping them entirely -- so we get like SOME_LONG_NAME from some-long-name rather than SOMELONGNAME, as the former is more readable. Appreciate that changing this for spaces might be breaking for existing consumers though.

[TWiStErRob]

Oh, yeah, definitely! Removal is hard to read, sorry.

[akashrpo]

This issue has been resolved in #94. Closing this now.