Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML parsing should be more strict #11892

Open
Aaron1011 opened this issue Jul 4, 2023 · 3 comments
Open

XML parsing should be more strict #11892

Aaron1011 opened this issue Jul 4, 2023 · 3 comments
Labels
A-avm2 Area: AVM2 (ActionScript 3) xml

Comments

@Aaron1011
Copy link
Member

quick_xml seems to accept XML like <>, which Flash's XML parser rejects. Some SWFs (like Scratch) do new XML(maybe_xml_data) and catch thrown error to detect invalid XML, so we need to match Flash's parsing behavior.

@Aaron1011 Aaron1011 added the xml label Jul 4, 2023
@Lord-McSweeney Lord-McSweeney added the A-avm2 Area: AVM2 (ActionScript 3) label Jul 4, 2023
@Lord-McSweeney
Copy link
Collaborator

AFAIK this is the opposite for AVM1, where XML parsing needs to be less strict.

@Aaron1011
Copy link
Member Author

Aaron1011 commented Jul 4, 2023

Opened tafia/quick-xml#622 upstream for one particular case of invalid XML being accepted.

@evilpie
Copy link
Collaborator

evilpie commented Sep 28, 2024

So that case should be fixed now, but I guess there are still other differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm2 Area: AVM2 (ActionScript 3) xml
Projects
None yet
Development

No branches or pull requests

3 participants