Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruffle freezes when loading any swf #13422

Closed
kreudom opened this issue Oct 3, 2023 · 3 comments
Closed

Ruffle freezes when loading any swf #13422

kreudom opened this issue Oct 3, 2023 · 3 comments
Labels
bug Something isn't working render-wgpu Issues relating to the wgpu renderer upstream-wgpu Caused by an upstream wgpu bug

Comments

@kreudom
Copy link

kreudom commented Oct 3, 2023

Describe the bug

When trying to run any swf file in Ruffle, nothing is displayed and the window freezes, sometimes causing the whole desktop to freeze for a while.

Ruffle runs without any problems if I launch it without specifying a swf file, but as soon as I try to load one, Ruffle freezes.

When I specify a swf file as a command line argument, Ruffle freezes immediately.

The freeze happens on every swf file I tried, even on Ruffle's test swf files (like tests/tests/swfs/avm1/add/test.swf).

I tried both the latest nightly release and building from source.

Expected behavior

Ruffle should be able to open files without freezing.

Affected platform

Desktop app

Operating system

Arch Linux x86_64

Browser

No response

Additional information

I used git bisect to track down the first commit that doesn't work for me: 2dcd783

I further narrowed down the issue: The previous commit works. If I update wgpu-hal to 0.17.1 using cargo update -p wgpu-hal, the freezing occurs again.

I then used cargo's patching mechanism to track down which wgpu commit of the 0.17.1 release introduced the issue. This is the first commit that causes the freezing for me: gfx-rs/wgpu@1d0a22b

I confirmed that Ruffle does not freeze on the latest commit if I revert gfx-rs/wgpu@1d0a22b.

I am not sure if this is a bug in Ruffle or wgpu, but I figured I'd report it here. Let me know if you need any additional information.

@kreudom kreudom added the bug Something isn't working label Oct 3, 2023
@Lord-McSweeney
Copy link
Collaborator

You should probably report this to wgpu on their repository page. If the issue was caused by a regression in wgpu, then we can't fix it.

@Lord-McSweeney Lord-McSweeney added upstream-wgpu Caused by an upstream wgpu bug render-wgpu Issues relating to the wgpu renderer labels Oct 4, 2023
@kreudom
Copy link
Author

kreudom commented Oct 5, 2023

Fixed in wgpu 0.17.2

It would just need to be merged into your ruffle-rs/wgpu fork

@kreudom
Copy link
Author

kreudom commented Oct 18, 2023

Fixed in #13561

@kreudom kreudom closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working render-wgpu Issues relating to the wgpu renderer upstream-wgpu Caused by an upstream wgpu bug
Projects
None yet
Development

No branches or pull requests

2 participants