Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grow Island: String path in removeMovieClip doesn't resolve #1665

Closed
relrelb opened this issue Nov 23, 2020 · 5 comments
Closed

Grow Island: String path in removeMovieClip doesn't resolve #1665

relrelb opened this issue Nov 23, 2020 · 5 comments

Comments

@relrelb
Copy link
Contributor

relrelb commented Nov 23, 2020

In Grow Island, when hearts are shown in the "Environmental" step of the solution, there is a heavy lag.

In DefineSprite 1044/frame 1/PlaceObject2 1043/onClipEvent(enterFrame), removeMovieClip is called with this as a string and not as an object, like in the rest of the code. As a result, action_remove_sprite mistakenly doesn't recognize the target as a movie clip, and doesn't remove it, causing a lag. Adding GetVariable after Push "this" works as expected and removes the lag.

I'm not sure how to fix it, but it seems that invoking resolve_target_path from resolve_target_display_object with first_element set to true solves the issue.

@Herschel
Copy link
Member

Trying a simple test with removeMovieClip("this"); doesn't seem to remove the clip; not sure what the difference is, so requires some more investigation.

removethis.zip

@BurstingBrain
Copy link

With the 13th of January 2021 release as a Firefox extension it works flawlessly for me on Windows 10

@relrelb
Copy link
Contributor Author

relrelb commented Jan 13, 2021

While most of the time the game works properly, there are some situations like mentioned above which cause lags.

Unfortunately, this bug still occurs.

@relrelb
Copy link
Contributor Author

relrelb commented Jan 23, 2021

Apparently, this is fixed between nightly-2021-01-16 and nightly-2021-01-17. However, the only commit between them (c2b768c) doesn't seem related.
Also, this occurs only on web.
@Herschel Do you have any idea how it was resolved?

@Herschel
Copy link
Member

My guess would be #2636 since this was an obfuscated SWF and I believe the code was in an onClipEvent handler, but haven't bisected myself.

@relrelb relrelb closed this as completed Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants