Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go Go Plant 2" doesn't do anything when the play button is clicked #2320

Closed
grishka opened this issue Jan 7, 2021 · 3 comments
Closed

"Go Go Plant 2" doesn't do anything when the play button is clicked #2320

grishka opened this issue Jan 7, 2021 · 3 comments
Assignees
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2)

Comments

@grishka
Copy link

grishka commented Jan 7, 2021

Log after it initializes and gets to the screen with the button: (there are many errors about "unknown tag codes" 253 and 255, and also "Stage.showMenu: unimplemented")
ruffle.rs-1610035505202.log
Then there are these errors when you click the button:

Uncaught Error: closure invoked recursively or destroyed already
    at Object.Wr (ruffle_web_bg.js:1686)
    at __wbindgen_throw (wasm chunk loading:1364)
    at wasm_bindgen::throw_str::hfa971da691102d09 (/demo/827bed83bde6126886bf.module.wasm:wasm-function[4958]:0x34ec53)
    at <dyn core::ops::function::FnMut<(A,)>+Output = R as wasm_bindgen::closure::WasmClosure>::describe::invoke::h21ecf576ef0c1ac8 (/demo/827bed83bde6126886bf.module.wasm:wasm-function[4642]:0x34d328)
    at P (ruffle_web_bg.js:240)
    at f (ruffle_web_bg.js:205)

Uncaught Error: closure invoked recursively or destroyed already
    at Object.Wr (ruffle_web_bg.js:1686)
    at __wbindgen_throw (wasm chunk loading:1364)
    at wasm_bindgen::throw_str::hfa971da691102d09 (/demo/827bed83bde6126886bf.module.wasm:wasm-function[4958]:0x34ec53)
    at <dyn core::ops::function::FnMut<(A,)>+Output = R as wasm_bindgen::closure::WasmClosure>::describe::invoke::h21ecf576ef0c1ac8 (/demo/827bed83bde6126886bf.module.wasm:wasm-function[4642]:0x34d328)
    at P (ruffle_web_bg.js:240)
    at HTMLElement.f (ruffle_web_bg.js:205)

SWF:
go-go-plant-2.swf.zip

OS: macOS 10.14.6, browser: Vivaldi 3.5.2115.81 (aka Chrome 87.0.4280.107)

@Toad06
Copy link
Member

Toad06 commented Jan 8, 2021

Thanks for the report. The source code is heavily obfuscated which is causing the "unknown tag codes" errors. Ruffle will need to handle that.

@Herschel Herschel added actionscript A-avm1 Area: AVM1 (ActionScript 1 & 2) labels Jan 8, 2021
@Herschel Herschel self-assigned this Jan 8, 2021
@grishka
Copy link
Author

grishka commented Jan 24, 2021

I just retested it now, and as of the 2021-01-24 nightly build, this game is fully playable. Save for the shadows (yeah I know bitmap effects), it works as good as in the Adobe flash player.

@Herschel
Copy link
Member

Fixed by #2636. Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-avm1 Area: AVM1 (ActionScript 1 & 2)
Projects
None yet
Development

No branches or pull requests

3 participants