Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

note requirement on wget package #15

Open
jimkring opened this issue Mar 9, 2024 · 2 comments
Open

note requirement on wget package #15

jimkring opened this issue Mar 9, 2024 · 2 comments

Comments

@jimkring
Copy link

jimkring commented Mar 9, 2024

It's worth noting that this action requires wget to be installed. I'm working with a container that doesn't already have it installed, so I had to install it. Not a big deal, but maybe work mentioning.

@rui314
Copy link
Owner

rui314 commented Mar 9, 2024

Alternatively, I could make a change to this Action so that it wouldn't try to install mold if wget is not available. Which do you prefer?

@jimkring
Copy link
Author

jimkring commented Mar 9, 2024

I would probably prefer that mold detects the missing dependency and reports a descriptive message like "The 'wget' package is required to setup mold. Please ensure it's installed on your system (e.g. using your system's package manager) and then try again."

Thanks again for mold -- it's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants