Nextcloud 22 support

[jhass]

Looks like OCP\User is gone?

{
  "reqId": "YWfknQaFHsuRAU0S-v1j1gAAAIU",
  "level": 3,
  "time": "2021-10-14T08:04:46+00:00",
  "remoteAddr": "2001:470:73b2:101:a84f:eda7:b034:48d9",
  "user": "mrzyx",
  "app": "index",
  "method": "GET",
  "url": "/index.php/apps/files/",
  "message": "Class 'OCP\\User' not found",
  "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:92.0) Gecko/20100101 Firefox/92.0",
  "version": "22.2.0.2",
  "exception": {
    "Exception": "Exception",
    "Message": "Class 'OCP\\User' not found",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/virtual/jhass/html/lib/private/AppFramework/App.php",
        "line": 156,
        "function": "dispatch",
        "class": "OC\\AppFramework\\Http\\Dispatcher",
        "type": "->",
        "args": [
          {
            "__class__": "OCA\\Files\\Controller\\ViewController"
          },
          "index"
        ]
      },
      {
        "file": "/var/www/virtual/jhass/html/lib/private/Route/Router.php",
        "line": 301,
        "function": "main",
        "class": "OC\\AppFramework\\App",
        "type": "::",
        "args": [
          "OCA\\Files\\Controller\\ViewController",
          "index",
          {
            "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
          },
          {
            "_route": "files.view.index"
          }
        ]
      },
      {
        "file": "/var/www/virtual/jhass/html/lib/base.php",
        "line": 1000,
        "function": "match",
        "class": "OC\\Route\\Router",
        "type": "->",
        "args": [
          "/apps/files/"
        ]
      },
      {
        "file": "/var/www/virtual/jhass/html/index.php",
        "line": 36,
        "function": "handleRequest",
        "class": "OC",
        "type": "::",
        "args": []
      }
    ],
    "File": "/var/www/virtual/jhass/html/lib/private/AppFramework/Http/Dispatcher.php",
    "Line": 158,
    "Previous": {
      "Exception": "Error",
      "Message": "Class 'OCP\\User' not found",
      "Code": 0,
      "Trace": [
        {
          "file": "/var/www/virtual/jhass/html/apps/files/lib/Controller/ViewController.php",
          "line": 136,
          "function": "include"
        },
        {
          "file": "/var/www/virtual/jhass/html/apps/files/lib/Controller/ViewController.php",
          "line": 276,
          "function": "renderScript",
          "class": "OCA\\Files\\Controller\\ViewController",
          "type": "->",
          "args": [
            "dropit",
            "list.php"
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 217,
          "function": "index",
          "class": "OCA\\Files\\Controller\\ViewController",
          "type": "->",
          "args": [
            "",
            "",
            null,
            false,
            null
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/lib/private/AppFramework/Http/Dispatcher.php",
          "line": 126,
          "function": "executeController",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->",
          "args": [
            {
              "__class__": "OCA\\Files\\Controller\\ViewController"
            },
            "index"
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/lib/private/AppFramework/App.php",
          "line": 156,
          "function": "dispatch",
          "class": "OC\\AppFramework\\Http\\Dispatcher",
          "type": "->",
          "args": [
            {
              "__class__": "OCA\\Files\\Controller\\ViewController"
            },
            "index"
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/lib/private/Route/Router.php",
          "line": 301,
          "function": "main",
          "class": "OC\\AppFramework\\App",
          "type": "::",
          "args": [
            "OCA\\Files\\Controller\\ViewController",
            "index",
            {
              "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
            },
            {
              "_route": "files.view.index"
            }
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/lib/base.php",
          "line": 1000,
          "function": "match",
          "class": "OC\\Route\\Router",
          "type": "->",
          "args": [
            "/apps/files/"
          ]
        },
        {
          "file": "/var/www/virtual/jhass/html/index.php",
          "line": 36,
          "function": "handleRequest",
          "class": "OC",
          "type": "::",
          "args": []
        }
      ],
      "File": "/var/www/virtual/jhass/html/apps/dropit/list.php",
      "Line": 4
    },
    "CustomMessage": "--"
  }
}

[unixfox]

I can reproduce the same issue.

[xarinatan]

+1, new installation and installed this plugin only to find it completely breaks my Files app, with the server log pointing to this plugin as the culprit.. Kind of a pain tbh, if it's gonna take a while to support 22 then I'd rather have it marked as incompatible for now, otherwise I'm sure a lot of Nextcloud users are going to run into their Files app magically no longer working after installing this plugin.

[tobiasKaminsky]

DropIt has max version of 18.
If you try to install it on new NC server, then it will warn you that you have to enable this untested app.
So new systems should be "safe".

I am unsure what happens, if you enabled untested app of DropIt on NC19 and then it breaks on 22.

In both cases it is due to using untested apps on non supported version, which might clash.

But I also would like to have an update of this cool app…

[xarinatan]

Maybe I did something wrong, but on my side it doesn't show as 'untested':

and there are also no notes about it being for version 18 or anything like that:

I mean don't get me wrong, it looks really nice and I'd love to use it, but right now it kinda seems like a trap for new users, because the Files app will just stop working with no clear message pointing to DropIt, only if you start looking at what files are being run in the server logs when the errors occur you realize that it is related.

That all said, thanks for people's efforts on this, it's awesome to see how many useful plugins there are for Nextcloud, it really makes it a very useful product!

[tobiasKaminsky]

Have you maybe enabled untested installation for dropIt in older Nextcloud versions?
I have no idea if this is remembered…

[p-bo]

Just in case it wasn't noticed - Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo