Chicken-egg issue with apply commands and GH protected branches

[gtirloni]

Say we do not want a PR to be merged unless it was applied by Atlantis to avoid configuration drift and to make sure what's in code actually exists in reality.

We add atlantis/apply check as a requirement in the Protected Branch configuration.

A new PR comes in, plan works fine and now the user wants to apply. Atlantis checks with GH but the PR is not mergeable because a successful atlantis/apply check is required (GH API returns "mergeable_state": "blocked".

Atlantis refuses to run apply commands because the PR is not mergeable (as specified in repos.yml).

This scenario seemed to work in the past (with 0.18.x at least), so we are not sure if it's simply ignored/no-op or if Atlantis 0.19 changed something and now it's working properly (but breaking our workflow).

Any advice?

[chicocvenancio]

This should be fixed in 0.19.5-pre, its what I thought was happening in #2310 but there is probably some other bug in that one.